zhangxinyao88 commented on code in PR #7766:
URL: https://github.com/apache/kyuubi/pull/7766#discussion_r4117953564
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -132,7 +128,7 @@
<dependency>
<groupId>org.apache.ranger</groupId>
- <artifactId>ranger-plugins-audit</artifactId>
+ <artifactId>ranger-audit-dest-hdfs</artifactId>
Review Comment:
> expected?
Right. In Ranger 2.7, `ranger-plugins-audit` is split into six destination
artifacts. I restored all six here, rather than only HDFS and Solr, and kept
the existing client-library exclusions.
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -221,6 +217,26 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.ranger</groupId>
+ <artifactId>ranger-audit-dest-solr</artifactId>
+ <version>${ranger.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.solr</groupId>
+ <artifactId>solr-solrj</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-client</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review Comment:
> why including these dependencies?
They replace the old aggregate artifact. Ranger loads destinations from
configuration, so adding only HDFS and Solr would leave the others unavailable.
The exclusions keep their external clients out of Kyuubi.
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -70,10 +70,6 @@
<groupId>org.apache.ranger</groupId>
<artifactId>ranger-plugin-classloader</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.apache.ranger</groupId>
Review Comment:
> not needed?
Not anymore. `ranger-plugins-audit` is no longer brought in by
`ranger-plugins-common` in 2.7; the six replacement artifacts are declared
explicitly below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
