micafer commented on PR #2066:
URL: https://github.com/apache/libcloud/pull/2066#issuecomment-6771915895

   I'm still checking this and I found two issues:
   
   Google Cloud DNS — get_record() uses a relative name in the API query.
   
   After parsing the normalized record ID, parts.name contains a relative name 
such as foo. However, the Cloud DNS API expects a fully qualified name such as 
foo.example.com. in the name query parameter.
   
   I believe this should use zone.fqdn(parts.name) instead. The corresponding 
test currently checks the endpoint URL but does not assert the query parameters.
   
   World Wide DNS — update_record() fails when extra=None.
   
   The new condition if "entry" in extra raises TypeError when the optional 
extra argument is omitted.
   
   Please guard against None and add a regression test covering an update 
without extra.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to