aaron-sierra commented on PR #2066:
URL: https://github.com/apache/libcloud/pull/2066#issuecomment-6774697625
> Google Cloud DNS — get_record() uses a relative name in the API query.
>
> After parsing the normalized record ID, parts.name contains a relative
name such as foo. However, the Cloud DNS API expects a fully qualified name
such as foo.example.com. in the name query parameter.
>
> I believe this should use zone.fqdn(parts.name) instead. The corresponding
test currently checks the endpoint URL but does not assert the query parameters.
You're right! I've added API parameter checking to `test_get_record()`, so
this doesn't slip through again:
```
self.assertEqual(len(sent.query["type"]), 1)
self.assertEqual(sent.query["type"].pop(), "A")
self.assertEqual(len(sent.query["name"]), 1)
self.assertEqual(sent.query["name"].pop(), "foo.example.com.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]