aaron-sierra commented on PR #2066:
URL: https://github.com/apache/libcloud/pull/2066#issuecomment-6864643800

   > World Wide DNS — update_record() fails when extra=None.
   > 
   > The new condition if "entry" in extra raises TypeError when the optional 
extra argument is omitted.
   > 
   > Please guard against None and add a regression test covering an update 
without extra.
   
   I'd like to omit this from the current merge request, if you agree. I've 
spent time trying to implement common/reusable function-call-level API test 
cases, but it needs review and refinement. I think this warrants a new issue.
   
   1. At least one other driver (`GandiDNSDriver`) needs similar fixes for 
`create_record()` and `update_record()`.
   2. Several drivers have explicit quirks that don't play nice with that sort 
of testing.
   3. The Google DNS driver testing relies on a mocked HTTP authentication 
endpoint that I have not managed to get working with this class of testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to