Github user garydgregory commented on a diff in the pull request:

    https://github.com/apache/logging-log4j2/pull/206#discussion_r210162846
  
    --- Diff: 
log4j-redis/src/main/java/org/apache/logging/log4j/redis/appender/RedisManager.java
 ---
    @@ -0,0 +1,104 @@
    +package org.apache.logging.log4j.redis.appender;
    +
    +import org.apache.logging.log4j.core.LoggerContext;
    +import org.apache.logging.log4j.core.appender.AbstractManager;
    +import org.apache.logging.log4j.core.net.ssl.SslConfiguration;
    +import redis.clients.jedis.Jedis;
    +import redis.clients.jedis.JedisPool;
    +import redis.clients.jedis.JedisPoolConfig;
    +import redis.clients.jedis.exceptions.JedisConnectionException;
    +
    +import java.net.URI;
    +import java.util.Queue;
    +import java.util.concurrent.TimeUnit;
    +
    +class RedisManager extends AbstractManager {
    --- End diff --
    
    Some basic class-level Javadoc would help maintenance.


---

Reply via email to