Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/logging-log4j2/pull/206#discussion_r210162868
--- Diff:
log4j-redis/src/main/java/org/apache/logging/log4j/redis/appender/LoggingJedisPoolConfiguration.java
---
@@ -0,0 +1,127 @@
+package org.apache.logging.log4j.redis.appender;
+
+import org.apache.logging.log4j.core.Core;
+import org.apache.logging.log4j.core.config.plugins.Plugin;
+import org.apache.logging.log4j.core.config.plugins.PluginAttribute;
+import org.apache.logging.log4j.core.config.plugins.PluginBuilderFactory;
+import redis.clients.jedis.JedisPoolConfig;
+
+@Plugin(name = "PoolConfiguration", category = Core.CATEGORY_NAME,
printObject = true)
+public class LoggingJedisPoolConfiguration extends JedisPoolConfig {
--- End diff --
Some basic class-level Javadoc would help maintenance.
---
