[
https://issues.apache.org/jira/browse/LOG4J2-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935324#comment-16935324
]
Anton Korenkov commented on LOG4J2-2674:
----------------------------------------
[~rgoers] It's actually not a renaming. I've created new marker constant for
composite configuration source. The reason lies in javadoc to NULL_SOURCE:
'ConfigurationSource to use with Configurations that do not require a "real"
configuration source.' In my opinion it may mislead in certain cases, because
composite configuration has multiple real sources. Like in our case, we are
using comparison to NULL_SOURCE to check do we have a 'real' configuration or
not.
> CompositeConfiguration misleading configuration source
> ------------------------------------------------------
>
> Key: LOG4J2-2674
> URL: https://issues.apache.org/jira/browse/LOG4J2-2674
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.8.1
> Reporter: Anton Korenkov
> Priority: Trivial
> Labels: pull-request-available
>
> Sometimes we are using CompositeConfiguration in our code. During last
> investigation we've found out that configuration source passed during
> constructor call is 'NULL_SOURCE'. It's a bit confusing because it conflicts
> with NULL_SOURCE definition
> {noformat}
> /**
> * ConfigurationSource to use with Configurations that do not require a
> "real" configuration source.
> */
> public static final ConfigurationSource NULL_SOURCE = new
> ConfigurationSource(new byte[0]);
> {noformat}
> because actually we have a 'composite' or 'multiple' configuration sources
> which will be used later to produce real configuration.
> The question is: do you mind to create 'COMPOSITE_SOURCE' constant and use it
> in CompositeConfiguration?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
