stephen-webb commented on a change in pull request #23:
URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418442671
##########
File path: src/cmake/FindAPR-Util.cmake
##########
@@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE
mark_as_advanced(APR_UTIL_CONFIG_EXECUTABLE)
if(EXISTS ${APR_UTIL_CONFIG_EXECUTABLE})
_apu_invoke(APR_UTIL_INCLUDE_DIR --includedir)
- _apu_invoke(APR_UTIL_LIBRARIES --link-ld)
+ if (APU_STATIC OR NOT BUILD_SHARED_LIBS)
+ _apr_invoke(_apr_util_link_args --link-ld)
Review comment:
Should all be 'apu' - I will fix those typos
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
