stephen-webb commented on a change in pull request #23:
URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418451027
##########
File path: src/cmake/FindAPR-Util.cmake
##########
@@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE
mark_as_advanced(APR_UTIL_CONFIG_EXECUTABLE)
if(EXISTS ${APR_UTIL_CONFIG_EXECUTABLE})
_apu_invoke(APR_UTIL_INCLUDE_DIR --includedir)
- _apu_invoke(APR_UTIL_LIBRARIES --link-ld)
+ if (APU_STATIC OR NOT BUILD_SHARED_LIBS)
+ _apr_invoke(_apr_util_link_args --link-ld)
+ string(REGEX MATCH "-L([^ ]*)" _apr_util_L_flag ${_apr_util_link_args})
Review comment:
The regex is designed to work with the output generated by the
'apu-1-config' installed by the APR-Util install.
I understand the Apache runtime will be merging APR-Util into APR in their
next release so this script does not need to handle any future changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
