stephen-webb commented on a change in pull request #23:
URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418444913
##########
File path: src/cmake/FindAPR.cmake
##########
@@ -33,7 +33,14 @@ find_program(APR_CONFIG_EXECUTABLE
mark_as_advanced(APR_CONFIG_EXECUTABLE)
if(EXISTS ${APR_CONFIG_EXECUTABLE})
_apr_invoke(APR_INCLUDE_DIR --includedir)
- _apr_invoke(APR_LIBRARIES --link-ld)
+ if (APR_STATIC OR NOT BUILD_SHARED_LIBS)
+ _apr_invoke(_apr_link_args --link-ld)
+ string(REGEX MATCH "-L([^ ]*)" _apr_L_flag ${_apr_link_args})
Review comment:
The regex is designed to work with the output generated by the
'apr-1-config' installed by APR install.
If** the -L and the path are separated, the logic would need to find the
argument after '-L'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
