[ 
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182751#comment-17182751
 ] 

Robert Middleton commented on LOGCXX-510:
-----------------------------------------

A note on the testing path: I encountered this the other week working on some 
Github actions, and it seems to be dependent on how windows finds DLLs: 
[https://docs.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-search-order#standard-search-order-for-desktop-applications]

 

I (partially) fixed it in this commit:  
[https://github.com/rm5248/logging-log4cxx/commit/3aa1812a1e2932d77add7c765f5e7d7aab335784#diff-930b1cecbcd3f0be696b6238ec765675]

It seems that Steven Webb at least did some stuff in the CMakeLists.txt in the 
test directory to handle this by adding the directory that the DLLs reside in 
to the PATH when running the tests.

 

Full file: 
[https://github.com/rm5248/logging-log4cxx/blob/b2a89d2317396f3567ab44414e5d0be28c8d1d68/src/test/cpp/CMakeLists.txt]

 

I haven't done a PR for this branch, as there's a rather significant number of 
test failures on Windows.  I tried to download a VM from Microsoft for Windows 
development, but Visual Studio as installed keeps having a lot of problems with 
CMake for some reason... (latest build on the branch: 
https://github.com/rm5248/logging-log4cxx/runs/977985817)

> Build problems using CMAKE and Visual Studio 2019 Community
> -----------------------------------------------------------
>
>                 Key: LOGCXX-510
>                 URL: https://issues.apache.org/jira/browse/LOGCXX-510
>             Project: Log4cxx
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 0.11.0
>            Reporter: Thorsten Schöning
>            Assignee: Thorsten Schöning
>            Priority: Major
>         Attachments: CMP00079.png, CMakeSettings.json, 
> cmake_settings_using_vs_gui.zip, missing_log4cxx_rc.png, 
> set_target_properties.png
>
>
> I just tested building log4cxx using CMAKE and Visual Studio 2019 Community. 
> Things failed and I want to use this bug to document everything that I've 
> found, because for some things I'm not sure how to handle them properly. Will 
> create a new branch to maintain the fixes I came along, so that those can at 
> best be later reviewed by others. The branch of interest is currently named 
> "logcxx_510_cmake_vs2019_compat".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to