[ 
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183013#comment-17183013
 ] 

Thorsten Schöning commented on LOGCXX-510:
------------------------------------------

The MS-docs pretty much make clear that PATH should be honoured in any case, 
but I think the problem is with CMAKE:

{quote}
ENVIRONMENT "TOTO=wonderful;key1=value1;key2=value2;PATH=${PATH_FOR_TESTS}"
{quote}

{quote}
ENVIRONMENT 
"TOTO=wonderful;key1=value1;key2=value2;PATH==${LOG4CXX_DLL_DIR}\;${APR_DLL_DIR}\;${APR_UTIL_DLL_DIR}"
{quote}

Are those lines adding to individual environment variables or replacing them 
entirely? I have the feeling of the latter, because that's pretty much what I 
see in ProcMon and can't work easily for e.g. "sed.exe".

Are "PATH=..." and "PATH==..." two different things or is the latter a mistake?

I additionally wonder why "LOG4CXX_DLL_DIR" doesn't seem to be properly 
honoured for me. Searching the CMAKE-files for that term, I only find one hit 
and it's not shown to be configured in Visual Studio as well. Doesn't that need 
something like "get_filename_component" like is used for APR as well?

> Build problems using CMAKE and Visual Studio 2019 Community
> -----------------------------------------------------------
>
>                 Key: LOGCXX-510
>                 URL: https://issues.apache.org/jira/browse/LOGCXX-510
>             Project: Log4cxx
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 0.11.0
>            Reporter: Thorsten Schöning
>            Assignee: Thorsten Schöning
>            Priority: Major
>         Attachments: CMP00079.png, CMakeSettings.json, 
> cmake_settings_using_vs_gui.zip, missing_log4cxx_rc.png, 
> set_target_properties.png
>
>
> I just tested building log4cxx using CMAKE and Visual Studio 2019 Community. 
> Things failed and I want to use this bug to document everything that I've 
> found, because for some things I'm not sure how to handle them properly. Will 
> create a new branch to maintain the fixes I came along, so that those can at 
> best be later reviewed by others. The branch of interest is currently named 
> "logcxx_510_cmake_vs2019_compat".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to