ams-tschoening commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r695473112
##########
File path: src/main/cpp/asyncappender.cpp
##########
@@ -50,7 +51,7 @@ AsyncAppender::AsyncAppender()
locationInfo(false),
blocking(true)
{
- dispatcher = std::thread( &AsyncAppender::dispatch, this );
+ dispatcher = ThreadUtility::instance()->createThread(
LOG4CXX_STR("AyncAppend"), &AsyncAppender::dispatch, this );
Review comment:
I wasn't aware of the length limit, so your shorter names make perfectly
sense. You are using them in most cases anyway already, no need to make it
different here:
* AsyncAppend vs. AsyncAppender
* FileWatch vs. FileWatchdog
* SocketAppend vs. SocketAppenderSkeleton
* SocketHub vs. SocketHubAppender
* TelnetAppend vs. TelnetAppender
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
