coldtobi commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697206398
##########
File path: src/main/cpp/threadutility.cpp
##########
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtility::preThreadBlockSignals(){
#if LOG4CXX_HAS_PTHREAD_SIGMASK
+ m_priv->creation_mutex.lock();
Review comment:
(Maybe I miss something but) I dont think a mutex is required, at least
not for the sigmask dance...
Oh, Update... now I got it... ThreadUtil is a singleton.. Maybe it
shouldn't? or the old sigmask should be stored as thread-local-data?
(my very own bikeshed color is that holding a mutex over function boundaries
is fragile long-term)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
