rm5248 commented on a change in pull request #68:
URL: https://github.com/apache/logging-log4cxx/pull/68#discussion_r697747208
##########
File path: src/main/cpp/threadutility.cpp
##########
@@ -44,19 +50,23 @@ void ThreadUtility::configureFuncs( ThreadStartPre
pre_start,
void ThreadUtility::preThreadBlockSignals(){
#if LOG4CXX_HAS_PTHREAD_SIGMASK
+ m_priv->creation_mutex.lock();
Review comment:
I'm not a huge fan of it either, but I couldn't think of a better way to
handle it. If you have a better idea I'd love to hear it.
The problem with using a thread local is that Thorsten's compiler [doesn't
support it](https://docwiki.embarcadero.com/RADStudio/Sydney/en/Thread_local),
but that's also on Windows and this is for *nix systems, so maybe we can do it
anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
