carterkozak commented on a change in pull request #732: URL: https://github.com/apache/logging-log4j2/pull/732#discussion_r794553848
########## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/LookupResult.java ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache license, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the license for the specific language governing permissions and + * limitations under the license. + */ + +package org.apache.logging.log4j.core.lookup; + +public interface LookupResult { + + /** Value of the lookup result. Never null. */ + String value(); + + /** + * True if the result should be re-evaluated for other lookups. + * This is used by {@link PropertiesLookup} to allow properties to be evaluated against other properties, + * because the configuration properties are completely trusted and designed with lookups in mind. It is + * unsafe to return true in most cases because it may allow unintended lookups to evaluate other lookups. + */ + default boolean allowRecursiveLookups() { + return false; + } Review comment: I don't think the name of this method is obvious enough. Perhaps `allowLookupEvaluationInValue`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
