carterkozak commented on a change in pull request #732:
URL: https://github.com/apache/logging-log4j2/pull/732#discussion_r801118459



##########
File path: 
log4j-core/src/main/java/org/apache/logging/log4j/core/config/PropertiesPlugin.java
##########
@@ -45,15 +47,62 @@ private PropertiesPlugin() {
     @PluginFactory
     public static StrLookup configureSubstitutor(@PluginElement("Properties") 
final Property[] properties,
                                                  @PluginConfiguration final 
Configuration config) {
-        if (properties == null) {
-            return new Interpolator(config.getProperties());
+        // For backwards compatibility, we unescape all escaped lookups when 
properties are parsed.
+        // This matches previous behavior for escaped components which were 
meant to be executed later on.
+        Property[] escapedProperties = new Property[properties == null ? 0 : 
properties.length];

Review comment:
       ```suggestion
           Property[] unescapedProperties = new Property[properties == null ? 0 
: properties.length];
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to