carterkozak commented on pull request #732:
URL: https://github.com/apache/logging-log4j2/pull/732#issuecomment-1030409561
I've added a bit of code to unescape escaped lookups, which will allow
existing properties to work as expected. Rather than `value.replace("$${",
"${")`, I'm using a `StrSubstitutor` with a lookup that always returns `null`
and doesn't understand defaults, this way original values are retained, but
escaped components are unescaped so that there's no regression from 2.17.0 and
earlier.
We had discussed the idea of making such a feature opt-in, however I feel
pretty strongly that it should be on-by-default, or shouldn't exist at all.
Reason being: In cases where it's needed, it would require a similar level of
effort to unescape lookups in logging configurations as to turn on the feature.
At this point, the question is:
Are more concerned with easy upgrades that don't break functionality, or
providing the cleanest, most straightforward design at the cost of requiring
some configuration changes?
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
