garydgregory commented on pull request #775: URL: https://github.com/apache/logging-log4j2/pull/775#issuecomment-1052020598
Why does any parser need to be in the API module when all configurations take place in the Core module? I don't think we should fatten up the API with parsers. Gary On Fri, Feb 25, 2022, 23:48 Matt Sicker ***@***.***> wrote: > > - Moves JsonReader from log4j-layout-json-template to log4j-api. > - Adds support for comments in parsing JSON for compatibility with > existing Jackson usage. > - Adds new default JsonConfigurationFactory implementation using this. > > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/logging-log4j2/pull/775 > Commit Summary > > - 0ce86d5 > <https://github.com/apache/logging-log4j2/pull/775/commits/0ce86d53676c93cb795ad9a0e452cb70ba7fb04e> > Move JsonReader to log4j-api > - 52870bb > <https://github.com/apache/logging-log4j2/pull/775/commits/52870bb38da349e3596069362a3b7b2ffcd0e501> > [LOG4J2-3415] Support JSON configuration using embedded JSON parser > > File Changes > > (13 files <https://github.com/apache/logging-log4j2/pull/775/files>) > > - *R* > log4j-api-test/src/test/java/org/apache/logging/log4j/util/JsonReaderTest.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-7e657749d5e562b7bef91f9468ed53a480bad205a623d3936c6a8f0e99cbcacc> > (8) > - *R* > log4j-api/src/main/java/org/apache/logging/log4j/util/JsonReader.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-be33448ffe79402e00b05b7aa72682f6dbfec689f58af4b7cbddcf8f48b759e9> > (18) > - *A* > log4j-core/src/main/java/org/apache/logging/log4j/core/config/jason/JsonConfiguration.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-fca62a0108d66d47357def2b14864217a55c9d0d30d28e25952908610594af33> > (247) > - *A* > log4j-core/src/main/java/org/apache/logging/log4j/core/config/jason/JsonConfigurationFactory.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-6ee15294c6a5ddfda9985fad6ccba2d0bc2b3c6f49a406f8e7fca678dbfe4d5a> > (45) > - *M* > log4j-core/src/main/java/org/apache/logging/log4j/core/config/json/JsonConfigurationFactory.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-d75c94f8a2dce34f76a8d0bb8e250a55ceb193025693896e4eced333e4d43b67> > (4) > - *M* > log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/CaseConverterResolver.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-17ad6fd3edd5c3a31d26d8fd0dc84f1edf4e3288d159c4b655ef5ca808fd412e> > (2) > - *M* > log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/EventAdditionalFieldInterceptor.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-a1aec8ee8b9be5f17da3f1166164c2daf30d344afdca342aec904c28535c8f7e> > (4) > - *M* > log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/resolver/TemplateResolvers.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-e6be11c215109f794d653f02972680c2d4dc41430c2e38867827a47e46591f5a> > (2) > - *M* > log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutAdditionalFieldTest.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-98ac627b4d8026ec91c85a8de7e97bbe15452866eba119d68c5e1c4476aa0edd> > (2) > - *M* > log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/TestHelpers.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-c1c522d67d4046c5a0dbdc8c031113eefd8877bb8d84549e4adaad711577030b> > (2) > - *M* > log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/CounterResolverTest.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-630011188b0cb7923058e2172b3e4c912bfc3de099126cecd0ae7a3696106dba> > (2) > - *M* > log4j-layout-template-json/src/test/java/org/apache/logging/log4j/layout/template/json/resolver/MessageResolverTest.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-ef9ad6d2540442829c2bfce7bdb5175e398436fa174714d5ebbf89d9b52096aa> > (4) > - *M* > log4j-perf/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutBenchmarkReport.java > <https://github.com/apache/logging-log4j2/pull/775/files#diff-037d3447c0a21641eeaf79476ac869ddba3ab9dd8a005fb6279ab8774e6b62a8> > (2) > > Patch Links: > > - https://github.com/apache/logging-log4j2/pull/775.patch > - https://github.com/apache/logging-log4j2/pull/775.diff > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j2/pull/775>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAJB6N4FWXCVDI5D4JLUOKDU5BLTFANCNFSM5PMAFRJA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
