vy commented on a change in pull request #775:
URL: https://github.com/apache/logging-log4j2/pull/775#discussion_r836108757
##########
File path:
log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/JsonReaderTest.java
##########
@@ -375,6 +376,11 @@ public void test_nesting() {
}})));
}
+ @Test
Review comment:
I'd prefer here a `@ParametrizedTest` touching different corner cases.
Further, the following cases are not tested:
1. multi-line comment blocks (should pass)
1. not closed comment blocks (should fail)
1. not opened comment blocks (should fail)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
