jvz commented on code in PR #1964:
URL: https://github.com/apache/logging-log4j2/pull/1964#discussion_r1391507145
##########
log4j-core-its/src/test/java/org/apache/logging/log4j/core/async/perftest/ResponseTimeTest.java:
##########
@@ -141,7 +141,7 @@ public static void main(final String[] args) throws
Exception {
runLatencyTest(logger, WARMUP_DURATION_MILLIS, WARMUP_COUNT,
loadMessagesPerSec, idleStrategy,
warmupServiceTmHistograms, warmupResponseTmHistograms,
threadCount);
System.out.println("-----------------Warmup done. load=" +
loadMessagesPerSec);
- if (!Constants.ENABLE_DIRECT_ENCODERS ||
!Constants.ENABLE_THREADLOCALS) {
+ if (!Constants.ENABLE_DIRECT_ENCODERS ||
!org.apache.logging.log4j.util.Constants.isUseThreadLocals()) {
Review Comment:
I didn't want to refactor all the use of constants in 2.x as that's
something related to the context-scoped properties feature introduced in 3.x.
However, if we have tests that would otherwise need to, say, modify a static
final field, then yes, I'd refactor this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
