vy commented on PR #1964: URL: https://github.com/apache/logging-log4j2/pull/1964#issuecomment-1809925996
> > @jvz, I miss a clear scope for this PR. To me it feels like (could very well be due to my lack of understanding) changes are at arbitrary places and doesn't much contribute to the PR goal: Java 17 support. > > The scope of this PR is to fix a ton of tests that fail in Java 17 or Java 21. Most of those tests were failing due to breaking encapsulation rules of Java such as trying to redefine a static final field somewhere. Believe me, I wouldn't be making changes to 2.x that aren't in scope of anything important! I'm all-in on the main branch. Okay. I would really appreciate it if you can update the description of the ticket accordingly. What is the goal? What is failing? The list of failures addressed, etc. One last remark: I would only address 17 and, if needed, worry about 21 in a follow-up ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
