ppkarwasz commented on code in PR #3080:
URL: https://github.com/apache/logging-log4j2/pull/3080#discussion_r1802650159
##########
log4j-slf4j2-impl/src/test/java/org/apache/logging/slf4j/LoggerContextTest.java:
##########
@@ -35,9 +35,9 @@ public void testCleanup() throws Exception {
factory.getLogger("test");
Set<LoggerContext> set = factory.getLoggerContexts();
final LoggerContext ctx1 = set.toArray(LoggerContext.EMPTY_ARRAY)[0];
- assertTrue("LoggerContext is not enabled for shutdown", ctx1
instanceof LifeCycle);
+ assertTrue(ctx1 instanceof LifeCycle, "LoggerContext is not enabled
for shutdown");
Review Comment:
```suggestion
assertInstanceOf(LifeCycle.class, ctx1, "LoggerContext is not
enabled for shutdown");
```
Could you change the assertions on `X instanceof Y` to use the new
`assertInstanceOf` assertions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
