AlbaHerrerias commented on PR #3080: URL: https://github.com/apache/logging-log4j2/pull/3080#issuecomment-2426899158
Thank you for the review and assistance, I have addressed now your requested changes. Please let me know if you'd like to request more. I will make the refactor of the `log4j-slf4j-impl` module. My plan is to make it as a new PR (as we have been doing; a PR per module), but if you'd rather me doing it in this PR, please let me know and I will do so. Also note that, with the removal of `junit-vintage-engine`, the tests of [`Log4j2_1482_Slf4jTest.java`](https://github.com/apache/logging-log4j2/blob/cbe7e91304cd0d3681a3c6eedc1782b25cb96242/log4j-slf4j2-impl/src/test/java/org/apache/logging/slf4j/Log4j2_1482_Slf4jTest.java) are not being executed (total of 2 tests). They extend from [`log4j-core-test/.../Log4j2_1482_Test.java`](https://github.com/apache/logging-log4j2/blob/cbe7e91304cd0d3681a3c6eedc1782b25cb96242/log4j-core-test/src/main/java/org/apache/logging/log4j/core/test/layout/Log4j2_1482_Test.java), currently written in JUnit 4. My coworker is refactoring those in https://github.com/apache/logging-log4j2/pull/3061. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
