SebTardif commented on PR #4127: URL: https://github.com/apache/logging-log4j2/pull/4127#issuecomment-4512524967
Thanks for the detailed suggestions @ramanathan1504! Added both: - **Failure test**: `testNoJarFileLeakOnFailure` — creates a JAR, requests a missing entry (`!/missing/file.xml`), and asserts no FD leak and no file lock after the failed load. Follows the same pattern as the existing `testNoJarFileLeak` and `testLoadConfigurationSourceFromJarFile` tests. - **Changelog entry**: `src/changelog/.2.x.x/fix_configuration_source_url_leak.xml` Spotless applied. All 4 ConfigurationSourceTest tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
