ramanathan1504 commented on PR #4127:
URL: https://github.com/apache/logging-log4j2/pull/4127#issuecomment-4513054003

   @SebTardif 
   
   I pushed a follow-up commit to address this in the PR branch.
   
   What I changed:
   - Updated `ConfigurationSource` to close only the already-opened 
`InputStream` on failure paths, so we avoid potential URL/JAR resource leaks.
   - Updated `ConfigurationSourceTest` to validate the failure case (missing 
JAR entry), confirm no file descriptor increase, and ensure the JAR is 
deletable afterward.
   
   Please avoid force-pushing in future updates so review history and inline 
comments remain easy to track.
   
   Thanks for the support!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to