SebTardif commented on PR #4127: URL: https://github.com/apache/logging-log4j2/pull/4127#issuecomment-4564339701
@vy Added a negative test in 4bfa56c. It injects a counting `HttpURLConnection` via a custom `URLStreamHandler` and asserts two things: 1. `disconnect()` is called on the error path (fails against the original code, which has no `finally` block) 2. `getInputStream()` is called exactly once (fails against the intermediate fix that re-invoked `getInputStream()` in the `finally` block instead of closing the tracked stream) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
