taegeonum commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r265445639
##########
File path: client/src/main/java/org/apache/nemo/client/ClientEndpoint.java
##########
@@ -164,7 +164,8 @@ public final Enum waitUntilJobFinish(final long timeout,
return stateTranslator.translateState(driverEndpoint.get().
waitUntilFinish(timeout - unit.convert(consumedTime,
TimeUnit.NANOSECONDS), unit));
} else {
- return PlanState.State.READY;
+ // This default value needs double checking.
+ return stateTranslator.translateState(PlanState.State.READY);
Review comment:
This is because driverEndpoint.get() == null indicates the program is
running? Is this correct @wonook ? and `driverEndpoint.get() == null`
guarantees running state?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
