taegeonum commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r385422663
##########
File path: client/src/main/java/org/apache/nemo/client/ClientEndpoint.java
##########
@@ -90,7 +90,12 @@ private boolean waitUntilConnected(final long timeout,
try {
if (driverEndpoint.get() == null) {
// If the driver endpoint is not connected, wait.
- return driverConnected.await(timeout, unit);
+ if (timeout < 1) {
Review comment:
or why don't you use `timeout == Long.MAX_VALUE `? and call
`waitUntilConnected(Long.MAX_VALUE, TimeUnit.SECONDS)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
