taegeonum commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r385424484
##########
File path: client/src/main/java/org/apache/nemo/client/ClientEndpoint.java
##########
@@ -176,17 +169,6 @@ public final Enum waitUntilJobFinish(final long timeout,
* @return the final state of this job.
*/
public final Enum waitUntilJobFinish() {
- if (driverEndpoint.get() != null) {
- return
stateTranslator.translateState(driverEndpoint.get().waitUntilFinish());
- } else {
- // The driver endpoint is not connected yet.
- final boolean driverIsConnected = waitUntilConnected();
-
- if (driverIsConnected) {
- return
stateTranslator.translateState(driverEndpoint.get().waitUntilFinish());
- } else {
- return PlanState.State.READY;
- }
- }
+ return waitUntilJobFinish(0, TimeUnit.MILLISECONDS);
Review comment:
`waitUntilJobFinish(DEFAULT_...,)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
