taegeonum commented on a change in pull request #203: [NEMO-360] Implementing 
an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267568454
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/dag/Edge.java
 ##########
 @@ -64,6 +64,15 @@ public final Integer getNumericId() {
     return Integer.parseInt(id.replaceAll("[^\\d.]", ""));
   }
 
+  /**
+   * Method to restore String ID from the numeric ID.
+   * @param numericId the numeric id.
+   * @return the restored string ID.
+   */
+  public static final String restoreId(final Integer numericId) {
 
 Review comment:
   This is an utility function, I think it would be good to place this method 
into utility class (`Utils` or `DagUtils`? )

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to