taegeonum commented on a change in pull request #203: [NEMO-360] Implementing 
an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267572231
 
 

 ##########
 File path: 
common/src/main/java/org/apache/nemo/common/ir/executionproperty/ExecutionProperty.java
 ##########
 @@ -42,6 +42,13 @@ public final T getValue() {
     return this.value;
   }
 
+  /**
+   * @return the class of the value type.
+   */
+  public final Class<? extends Serializable> getValueClass() {
 
 Review comment:
   Why do you add this function? Can't we extract this class by 
`.getValue().getClass()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to