taegeonum commented on a change in pull request #203: [NEMO-360] Implementing
an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267575429
##########
File path:
compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/NemoOptimizer.java
##########
@@ -54,11 +58,17 @@
/**
* @param dagDirectory to store JSON representation of intermediate DAGs.
* @param policyName the name of the optimization policy.
+ * @param environmentType the environment type of the workload to optimize
the DAG for.
+ * @param clientRPC the RPC channel to communicate with the client.
*/
@Inject
private NemoOptimizer(@Parameter(JobConf.DAGDirectory.class) final String
dagDirectory,
- @Parameter(JobConf.OptimizationPolicy.class) final
String policyName) {
+ @Parameter(JobConf.OptimizationPolicy.class) final
String policyName,
+ @Parameter(JobConf.EnvironmentType.class) final String
environmentType,
+ final ClientRPC clientRPC) {
this.dagDirectory = dagDirectory;
+ this.environmentType = environmentType;
Review comment:
Do we have to add environmentType? Why do we need this variable and when is
it used? Actually, the environment type isn't important because the behavior
depends on the optimization policy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
