johnyangk commented on a change in pull request #222: [NEMO-350] Implement Off-heap SerializedMemoryStore & [NEMO-384] Implement DirectByteBufferInputStream for Off-heap SerializedMemoryStore URL: https://github.com/apache/incubator-nemo/pull/222#discussion_r295148407
########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/partition/SerializedPartition.java ########## @@ -45,11 +48,13 @@ private volatile boolean committed; // Will be null when the partition is committed when it is constructed. @Nullable - private final DirectByteArrayOutputStream bytesOutputStream; + private final DirectByteBufferOutputStream bytesOutputStream; Review comment: I have a feeling that this class can be refactored into multiple classes, without null fields, but that's probably out of the scope of this PR. Can you file a JIRA issue to refactor this class, and add a TODO comment? Reference for the TODO comment: https://github.com/apache/incubator-nemo/blob/master/runtime/master/src/main/java/org/apache/nemo/runtime/master/scheduler/BatchScheduler.java#L567 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
