johnyangk commented on a change in pull request #222: [NEMO-350] Implement
Off-heap SerializedMemoryStore & [NEMO-384] Implement
DirectByteBufferInputStream for Off-heap SerializedMemoryStore
URL: https://github.com/apache/incubator-nemo/pull/222#discussion_r295137289
##########
File path:
common/src/main/java/org/apache/nemo/common/DirectByteBufferOutputStream.java
##########
@@ -140,38 +140,45 @@ public void write(final byte[] b, final int off, final
int len) {
final int arraySize = pageSize * (dataList.size() - 1) +
lastBuf.position();
final byte[] byteArray = new byte[arraySize];
int start = 0;
- int byteToWrite;
- for (final ByteBuffer temp : dataList) {
+ for (final ByteBuffer buffer : dataList) {
// ByteBuffer has to be shifted to read mode by calling
ByteBuffer.flip(),
// which sets limit to the current position and sets the position to 0.
// Note that capacity remains unchanged.
- temp.flip();
- byteToWrite = temp.remaining();
- temp.get(byteArray, start, byteToWrite);
+ final ByteBuffer dupBuffer = buffer.duplicate();
+ dupBuffer.flip();
+ final int byteToWrite = dupBuffer.remaining();
+ dupBuffer.get(byteArray, start, byteToWrite);
start += byteToWrite;
}
- // The limit of the last buffer has to be set to the capacity for
additional write.
- lastBuf.limit(lastBuf.capacity());
return byteArray;
}
/**
* Returns the list of {@code ByteBuffer}s that contains the written data.
- * Note that by calling this method, the existing list of {@code
ByteBuffer}s is cleared.
*
* @return the {@code LinkedList} of {@code ByteBuffer}s.
*/
- public List<ByteBuffer> getBufferListAndClear() {
- List<ByteBuffer> result = dataList;
- dataList = new LinkedList<>();
- for (final ByteBuffer buffer : result) {
- buffer.flip();
+ public List<ByteBuffer> getBufferList() {
+ List<ByteBuffer> result = new ArrayList<>(dataList.size());
+ for (final ByteBuffer buffer : dataList) {
+ final ByteBuffer dupBuffer = buffer.duplicate();
Review comment:
Ditto on duplicate().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
