johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap
memory management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307110360
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/block/FileBlock.java
##########
@@ -84,6 +103,7 @@ public FileBlock(final String blockId,
this.serializer = serializer;
this.filePath = filePath;
this.metadata = metadata;
+ this.memoryPoolAssigner = null;
Review comment:
It'd be good to avoid null assignments. Please remove L97-L106.
You can pass in memoryPoolAssigner in GlusterFileStore#getBlockFromFile,
which appears to be the only place this constructor is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
