johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap
memory management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307128700
##########
File path:
runtime/executor/src/test/java/org/apache/nemo/runtime/executor/data/BlockTest.java
##########
@@ -42,6 +42,7 @@
public final class BlockTest {
private Serializer serializer;
private Map<Integer, List<Integer>> testData;
+ private static final MemoryPoolAssigner memoryPoolAssigner = new
MemoryPoolAssigner(1, 32);
Review comment:
This should be initialized upon setUp() (`@Before`), similar to the
serializer variable.
If not, we're reusing the variable across `@Test`s, which might cause
undesirable side effects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
