johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap
memory management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307127878
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/GlusterFileStore.java
##########
@@ -70,7 +73,8 @@ public Block createBlock(final String blockId) {
final String filePath = DataUtil.blockIdToFilePath(blockId, fileDirectory);
final RemoteFileMetadata metadata =
RemoteFileMetadata.create(DataUtil.blockIdToMetaFilePath(blockId,
fileDirectory));
- return new FileBlock<>(blockId, serializer, filePath, metadata);
+ final MemoryPoolAssigner memoryPoolAssigner = getMemoryPoolAssigner();
Review comment:
Very very minor suggestion (here and other FileStores): call
getMemoryPoolAssigner() directly in L77 to reduce the number of variables?
return new FileBlock(..., getMemoryPoolAssigner())
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
