johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap
memory management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307126716
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/AbstractBlockStore.java
##########
@@ -28,14 +29,18 @@
*/
public abstract class AbstractBlockStore implements BlockStore {
private final SerializerManager serializerManager;
+ private final MemoryPoolAssigner memoryPoolAssigner;
/**
* Constructor.
*
* @param serializerManager the coder manager.
+ * @param memoryPoolAssigner the memory pool assigner.
*/
- protected AbstractBlockStore(final SerializerManager serializerManager) {
+ protected AbstractBlockStore(final SerializerManager serializerManager,
Review comment:
Remove the `protected` modifier here and others (i.e., use no modifier). My
Intellij recommends it.
See https://stackoverflow.com/a/215505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
