wonook commented on a change in pull request #274: [NEMO-429] SWPP TEAM12 Code
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/274#discussion_r353299076
##########
File path:
compiler/frontend/spark/src/main/java/org/apache/nemo/compiler/frontend/spark/transform/HDFSTextFileTransform.java
##########
@@ -36,9 +36,9 @@
*
* @param <I> input type.
*/
-public final class HDFSTextFileTransform<I> extends
NoWatermarkEmitTransform<I, String> {
+public final class HDFSTextFileTransform<I> extends
NoWatermarkEmitTransform<I, String> { //NOSONAR
private final String path;
- private Path fileName;
+ private Path fileName; //NOSONAR
private List<I> elements;
Review comment:
Please revert the change made on line 39, and make the variables declared on
line 41 and 42 `transient` to remove the code smell. You can declare `private
transient ...` to make the changes. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
