wonook commented on a change in pull request #274: [NEMO-429] SWPP TEAM12 Code Smell Fix URL: https://github.com/apache/incubator-nemo/pull/274#discussion_r353297735
########## File path: common/src/main/java/org/apache/nemo/common/ir/vertex/LoopVertex.java ########## @@ -34,7 +34,7 @@ import java.util.HashSet; import java.util.Map; import java.util.Set; -import java.util.function.IntPredicate; +import java.util.function.IntPredicate; //NOSONAR Review comment: Let's revert this change on the import line. This isn't applicable. Instead, let's make the `terminationCondition` variable transient on line 59. You can declare it as `private transient IntPredicate`... there and it will solve the issue 👍 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
