wonook commented on a change in pull request #274: [NEMO-429] SWPP TEAM12 Code
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/274#discussion_r360912764
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/task/SourceVertexDataFetcher.java
##########
@@ -55,9 +55,9 @@
if (!bounded) {
this.watermarkTriggerService = Executors.newScheduledThreadPool(1);
- this.watermarkTriggerService.scheduleAtFixedRate(() -> {
- watermarkTriggered = true;
- }, WATERMARK_PERIOD, WATERMARK_PERIOD, TimeUnit.MILLISECONDS);
+ this.watermarkTriggerService.scheduleAtFixedRate(() ->
+ watermarkTriggered = true
+ , WATERMARK_PERIOD, WATERMARK_PERIOD, TimeUnit.MILLISECONDS);
Review comment:
I think these lines are causing the checkstyle error. Can you append the
comma at the end of line 59, instead of at the beginning of line 60?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
