johnyangk commented on a change in pull request #270: [NEMO-429] SWPP TEAM4
Code Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/270#discussion_r353590078
##########
File path: common/src/main/java/org/apache/nemo/common/StateMachine.java
##########
@@ -288,11 +291,11 @@ public Builder setInitialState(final Enum stateToSet) {
*/
public Builder addTransition(final Enum from, final Enum to, final String
description) {
if (!stateEnumSet.contains(from)) {
- throw new RuntimeException("A state " + from + " should be added
first");
+ throw new RuntimeException(RE_prefix + from + RE_suffix);
}
Review comment:
checkState(from)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
