johnyangk commented on a change in pull request #270: [NEMO-429] SWPP TEAM4
Code Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/270#discussion_r353590968
##########
File path:
compiler/frontend/spark/src/main/java/org/apache/nemo/compiler/frontend/spark/transform/GroupByKeyTransform.java
##########
@@ -34,7 +34,7 @@
* @param <K> key type.
* @param <V> value type.
*/
-public final class GroupByKeyTransform<K, V> extends
NoWatermarkEmitTransform<Tuple2<K, V>, Tuple2<K, Iterable<V>>> {
+public final class GroupByKeyTransform<K extends Serializable, V extends
Serializable> extends NoWatermarkEmitTransform<Tuple2<K, V>, Tuple2<K,
Iterable<V>>> {
Review comment:
Unfortunately, this doesn't work when processing non-Serializable data
elements.
Revert this change, and instead add a TODO to
https://issues.apache.org/jira/browse/NEMO-431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
