johnyangk commented on a change in pull request #270: [NEMO-429] SWPP TEAM4
Code Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/270#discussion_r353589581
##########
File path: common/src/main/java/org/apache/nemo/common/StateMachine.java
##########
@@ -230,6 +230,9 @@ public String toString() {
* Builder that builds a StateMachine.
*/
public static final class Builder {
+ private final String RE_prefix = "A state "
Review comment:
Please remove this variable.
Can you use this private method instead?
```java
private void checkState(final Enum state) {
if (!stateEnumSet.contains(from)) {
throw new RuntimeException("State " + state + " should be added first");
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
