wonook commented on a change in pull request #279: [NEMO-420] OffHeapMemory
configuration only supports a single type of executor
URL: https://github.com/apache/incubator-nemo/pull/279#discussion_r366187914
##########
File path:
runtime/master/src/main/java/org/apache/nemo/runtime/master/resource/ResourceSpecification.java
##########
@@ -29,22 +29,34 @@
private final String containerType;
private final int capacity;
private final int memory;
+ private final double maxOffheapRatio;
+ private final int maxOffheapMb;
private final int poisonSec; // -1 if this resources is not poisoned
public ResourceSpecification(final String containerType,
final int capacity,
final int memory) {
- this(containerType, capacity, memory, -1);
+ this(containerType, capacity, memory, 0.02, -1);
}
public ResourceSpecification(final String containerType,
Review comment:
I think this constructor wouldn't be needed, as the constructor above is
only available for testing. Let's remove this unused constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
