DifferentSC commented on a change in pull request #279: [NEMO-420]
OffHeapMemory configuration only supports a single type of executor
URL: https://github.com/apache/incubator-nemo/pull/279#discussion_r366189445
##########
File path: conf/src/main/java/org/apache/nemo/conf/JobConf.java
##########
@@ -332,6 +316,22 @@
public final class ExecutorId implements Name<String> {
}
+ /**
+ * Maximum off-heap memory ratio to the total memory in the executor.
+ */
+ @NamedParameter(doc = "The maximum ratio of off-heap memory size to the
total memory size.",
+ short_name = "max_offheap_ratio", default_value = "0.02")
Review comment:
Why `0.02`? `0.02` is smaller than the previous default value `0.2`, but it
is basically same in that some portion of executor on-heap memory is allocated
in an unnoticeable way. I think we'd better make it to `0`, and enable off-heap
memory management only when this parameter becomes bigger than 0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
