DifferentSC commented on a change in pull request #279: [NEMO-420]
OffHeapMemory configuration only supports a single type of executor
URL: https://github.com/apache/incubator-nemo/pull/279#discussion_r366190257
##########
File path:
runtime/master/src/main/java/org/apache/nemo/runtime/master/RuntimeMaster.java
##########
@@ -313,11 +314,15 @@ public void requestContainer(final String
resourceSpecificationString) {
final TreeNode resourceNode = jsonRootNode.get(i);
final String type =
resourceNode.get("type").traverse().nextTextValue();
final int memory =
resourceNode.get("memory_mb").traverse().getIntValue();
+ final double maxOffheapRatio =
+ (resourceNode.path("max_offheap_ratio").traverse().nextToken() ==
JsonToken.VALUE_NUMBER_FLOAT)
+ ?
resourceNode.path("max_offheap_ratio").traverse().getFloatValue() : 0.02;
Review comment:
Same here too. I see no good rationales on setting the default value to
`0.02`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
