wonook commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r385617964
##########
File path: client/src/main/java/org/apache/nemo/client/ClientEndpoint.java
##########
@@ -154,7 +146,7 @@ public final Enum waitUntilJobFinish(final long timeout,
// The driver endpoint is not connected yet.
final long currentNano = System.nanoTime();
final boolean driverIsConnected;
- if (DEFAULT_DRIVER_WAIT_IN_MILLIS < unit.toMillis(timeout)) {
+ if (timeout > 0 && DEFAULT_DRIVER_WAIT_IN_MILLIS <
unit.toMillis(timeout)) {
Review comment:
Oh here, it actually calls for the max value between the DEFAULT value and
timeout, so I'll implement it accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
