wonook commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r385618222
##########
File path:
runtime/master/src/main/java/org/apache/nemo/runtime/master/PlanStateManager.java
##########
@@ -445,18 +445,7 @@ private void onPlanStateChanged(final PlanState.State
newState) {
* @return the final state of this plan.
*/
public PlanState.State waitUntilFinish() {
- finishLock.lock();
- try {
- while (!isPlanDone()) {
- planFinishedCondition.await();
- }
- } catch (final InterruptedException e) {
- LOG.warn("Interrupted during waiting the finish of Plan ID {}", planId);
- Thread.currentThread().interrupt();
- } finally {
- finishLock.unlock();
- }
- return getPlanState();
+ return waitUntilFinish(0, TimeUnit.MILLISECONDS);
Review comment:
🆗 I'll use Long.MAX_VALUE instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
